Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !4485

i#4091: Fix crash due to AMD stack segment bug

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i4091-amd-ss-mode-switch into master Oct 12, 2020
  • Overview 5
  • Commits 2
  • Pipelines 0
  • Changes 7

On AMD there is a processor bug where the stack segment descriptor is corrupted after a mode switch from 64-bit to 32-bit which coincides with a thread context switch. We fix that by re-loading the descriptor from the selector, using the value observed at initialization time.

Duplicate symbol errors which are somehow raised in VS2017 with the new drlibc call from the core are resolved by moving d_r_internal_error and d_r_ignore_assert to their own source files.

Tested the code path on an Intel processor. Will ask those with AMD processors to test it out before committing.

Fixes #4091 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i4091-amd-ss-mode-switch