Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !4469

i#4461: Skip stolen register on drcachesim filter barriers

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i4461-drreg-stolen-drcachesim into master Oct 02, 2020
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Do not try to get the application value of the stolen register on the jump barrier used for drreg parity in filtered drcachesim instrumentation.

Enable thread filtering on non-x86: there is no missing support there.

Tested by locally enabling the tool.drcacheoff.burst_threadfilter test (it is disabled for AArch64 because of the #2007 (closed) link failure in some toolchains), working around #4468 (closed) with "-steal_register 25", and confirming that the drreg failure disappears with the fix here.

This is needed for the forthcoming new global filter for drcachesim (#4462 (closed)), in addition to the thread filter feature. An enabled-on-AArch64 test should be added as part of that feature to serve as a regression test here, if #2007 (closed) has not been resolved by then to enable the thread filter test.

Issue: #4461 (closed), #4462 (closed) Fixes #4461 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i4461-drreg-stolen-drcachesim