Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !4466

i#4457: Fix clobbered register on detach

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i4457-arm-detach-x0 into master Sep 30, 2020
  • Overview 4
  • Commits 2
  • Pipelines 0
  • Changes 7

Generates a special fcache_enter_gonative routine for AArch64 (now it matches other architectures) to restore the stolen register and to avoid clobbering x0 on detach.

The new generated code required adding negative displacement support to XINST_CREATE_{load,store} and tweaking some other defines.

Since on Aarch64 we can't jump through memory or write to the PC, for now we assume we're at an ABI boundary and we clobber a caller-saved register.

Augments the api.detach test to use the _with_stats variant, which reproduces the original crash without the fix.

Fixes #4457 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i4457-arm-detach-x0