Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !4439

i#4438: Drop delayable signals arriving during thread exit

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i4438-signal-exiting-thread into master Sep 08, 2020
  • Overview 6
  • Commits 1
  • Pipelines 0
  • Changes 1

Checks for and drops delayable signals that arrive while a thread is exiting, which is a fragile time with data structures in inconsistent states.

Tested on the threadsig app with 50 threads, where the assert was seen every time before on a local machine and is now gone. I do not think we can reliably happen to hit this with a regression test on the CI machines where core counts are lower and load is higher, and we can't easily force it with application synchronization since it relies on signals arriving while in DR code, so I'm living with just the manual test.

Fixes #4438 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i4438-signal-exiting-thread