Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !4300

i#4299: Fix cti_short_rewrite detection and inversion for addr-prefixed jcxz/jecxz

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/nextsilicon-itay-bookstein/fix_jecxz_detection into master May 15, 2020
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: nextsilicon-itay-bookstein

In x86, jcxz has an 0x67 prefix. In x64, jecxz has an 0x67 prefix. The code in instr_is_cti_short_rewrite() does not take that into account when the pc argument is not NULL. The code in instr_invert_cbr does not take that into account when verifying and inverting the cbr, using wrong offsets in that case. This fix checks for the 0x67 prefix in both unaddressed cases so that the checks against the instruction bytes pass as they should.

Issue: #4299 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/nextsilicon-itay-bookstein/fix_jecxz_detection