Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !4236

i#4159 marker overflow: Handle expected drcachesim marker overflows

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i4159-crash-many-markers into master Mar 31, 2020
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 2

For drcachesim post-processing of explicit instr entries such as for filtered traces, do not output non-xfer markers post-instr and just exit back to the main loop instead, to avoid overflowing the buffer with potentially unimited strings of markers before the next filtered instr or memref entry.

For marker output during tracing, add an explicit check and buffer dump when the redzone is hit, as a safety step, even though today's code should not reach it.

Add a release-build check for hitting the buffer size so we can detect pathological missing-post-call stacked function markers. Fully handling that is left for future work.

Issue: #4159

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i4159-crash-many-markers