Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !4195

i#4187: Build a hashtable for faster ELF symbol lookups

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i4187-drsym-elf-slow into master Mar 18, 2020
  • Overview 8
  • Commits 4
  • Pipelines 0
  • Changes 5

Instead of a linear search through the symbol table on every lookup, on the first lookup drsyms now builds a hashtable of all symbol variants and uses it on subsequent lookups.

Adds a new option to the drcontainers hashtable to supply a key freeing callback, needed here because we are duplicating most strings ourselves before adding and do not want to have drcontainers re-duplicate.

Adds a -verbose 1 notification for libraries taking long amounts of time to be processed, for easier diagnostics in the future.

Performance-tested on large applications where it reduces drcachesim -record_heap query times by 5x for less-optimized code and 2x for highly-optimized code.

Fixes #4187 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i4187-drsym-elf-slow