Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !4073

i#4067 Appveyor hangs: Disable popups in Windows tests

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i4067-appveyor-hang into master Feb 01, 2020
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 5

Expands the pop-up disabling in drcachesim's launcher to warnings and errors as well as asserts.

Applies the same MSVC message box disabling to the tests by adding it to INIT() in tools.h.

Tested on win32.tls.exe which asserts on Win10.

Also fixes the assert in win32.tls on win8+ by switching from raw NtCreateThread to high-level thread creation, with an allowance added to the core to let this test in DEBUG target our nudge handler. This also makes it easy to enable the test for 64-bit mode after all that low-level code is removed.

Issue: #4067

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i4067-appveyor-hang