Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !4061

i#4060: Switch raw2trace from a per-instr hashtable to a per-block ha…

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i4060-raw2trace-perblock-hashtable into master Jan 27, 2020
  • Overview 8
  • Commits 2
  • Pipelines 0
  • Changes 2

…shtable

Refactors raw2trace's instruction record keeing to store a vector of instructions inside a per-block structure. The per-block structure is hashed instead of individual instructions, and with a last-block cache, lookups are greatly reduced. This improves performance (by 18% with no i/o) and eliminates the importance of using hashtable_t, allowing us to switch to a C++ hashtable as part fo moving raw2trace away from full DR and to drdecode for #3316 (closed).

Further refactors set_instr_summary() with create_instr_summary() to avoid an extra hashtable lookup inside get_instr_summary().

Also moves va_start inside the if() in log() to reduce the time spent there when logging is off.

Issue: #4060 (closed), #3316 (closed) Fixes #4060 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i4060-raw2trace-perblock-hashtable