Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !3960

i#3926: Do not clone label callbacks.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Hendrik Greving requested to merge i2985-add-drx-event-restore-support-avx2-gather into master Nov 21, 2019
  • Overview 17
  • Commits 6
  • Pipelines 0
  • Changes 3

Label callbacks are called every time an instruction is destroyed if the instruction is a label instruction and the field is valid. When cloning an instruction, we can't blindly copy the label callback field causing it to be called when the cloned instruction is destroyed. We are adding a note to the docs of instr_clone() and prevent the field from being copied.

Fixes #3926 (closed) Issue: #3962 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i2985-add-drx-event-restore-support-avx2-gather