Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !3887

i#3886: Compute alignment of MachO segments and do not page align

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i3886-macho-align into master Oct 10, 2019
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 3

We were previously blindly page-aligning MachO segments, yet on Catalina libraries have sub-page alignment and DR fails due to library overlap. We fix this by computing the alignment from the section alignments, but in the end I'm just leaving the given addresses since they're already aligned. We also relax a curiosity about all segments having the same alignment to only apply to ELF.

Fixes #3886 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i3886-macho-align