Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !3860

i#2924: Support building with VS2017

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i2924-vs2017 into master Sep 29, 2019
  • Overview 1
  • Commits 6
  • Pipelines 0
  • Changes 65

Fixes a whole bunch of compiler warnings when built with VS2017. Most of these are small, local changes. Significant changes are:

  • Changes the "PFX" format string macro from %x-based to %p-based, in order to support enabling format string warnings. This is now possible because on Windows we use our own printing code, rather than the ntdll code, making the %p style consistent across platforms. We do not make this change for native test apps, to avoid breaking the golden output.
  • Updates the minimum CMake version to 3.7 (the min for VS2017).

Changing Travis to use VS2017 will be done separately.

Issue: #2924 (closed) Issue: #1893

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i2924-vs2017