Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !3765

i#3759: Fix mmap handling conflicts

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i3759-mmap-exec into master Aug 02, 2019
  • Overview 6
  • Commits 6
  • Pipelines 0
  • Changes 8

Fixes problems with pre-syscall versus post-syscall mmap handling which can lead to asserts. Adds a check-only version of app_memory_protection_change() for use in pre-syscall, delaying all vmarea updates to post-syscall. Adds protection change checking inside app_memory_allocation(), simplifying caller usage and providing broader coverage of mmap behavior.

Adds a vmm attribute to all_memory_areas and disallows merging across that boundary, to match kernel behavior and avoid mismatch warnings with the above fix in place which does extra memory querying on each mmap.

Adds some mmap sequences to linux.mmap to provide some test coverage for these particular page protection change orderings.

Fixes #3759 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i3759-mmap-exec