Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !3723

i#3722: Fix receiving third parameter in our_cpuid.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Hendrik Greving requested to merge i3722-our-cpuid-fix-arg3 into master Jul 08, 2019
  • Overview 7
  • Commits 2
  • Pipelines 0
  • Changes 1

In Unix 64-bit mode, the third parameter is passed in rdx, which was clobbered when reading the second parameter. Switching with writing to rcx works, because rcx is the fourth parameter in Unix 64-bit, and the first in Windows 64-bit.

Tested by running through debugger and spot-checking feature bits.

Fixes #3722 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i3722-our-cpuid-fix-arg3