Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !3676

i#3674: Add stack alignment to test calling "vfprintf".

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Hendrik Greving requested to merge i3674-print-crash-stack-alignment into master Jun 06, 2019
  • Overview 29
  • Commits 13
  • Pipelines 0
  • Changes 3

An Ubuntu 18 system's libc, even with older gcc versions 4.8 (we did not try < 4.5), decided to callee-save a xmm register on the stack. This patch aligns the stack in the function in the test that is calling vfprintf. This problem generally affects all functions that we are hand-coding in asm and calling from a test. Absent a complete review of all hand-coded functions in the code base, this fixes this one only single case where a test failure was observed.

Fixes #3674 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i3674-print-crash-stack-alignment