Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !3649

Fix for #3633

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/deroko/fix-3633 into master May 27, 2019
  • Overview 14
  • Commits 5
  • Pipelines 0
  • Changes 2

Created by: deroko

Temporarily fixes issue on Windows 1903 where FLS data is not held in PEB anymore. This data is now spare data to keep PEB alignment.

Fix consists of avoiding app_peb->FlsBitmap when it doesn't exist. DynamoRIO will keep old FLS format in private_peb thus there is no problem when running on 1903.

Better solution would be to put FLS data in global variables inside of redir_ntdll.c thus there is no need to worry about if we are running on older windows or 1903, as anyhow private_peb FLS is initialized always from redir_ntdll.c so there would be no difference.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/deroko/fix-3633