Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !3531

i#3526: Apply scheme of i#2089 to client threads.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Hendrik Greving requested to merge i3526-invalidate-tls-client-threads into master Apr 10, 2019
  • Overview 16
  • Commits 5
  • Pipelines 0
  • Changes 2

When creating client threads, we still attempted to invalidate the thread's TLS by writing a null selector to its segment register. In 64-bit mode, this seemed to work most of the time because presumably Intel and AMD are then zero'ing out the the hidden segment's base. Intel doesn't precisely describe this in Vol. 3A 3.4.4.

This patch applies the same scheme introduced and described in #2089 (closed).

Before this patch, the test code_api|client.thread ran into all kinds of assertions, because the client thread interfered with the parent's TLS. These failures are now gone.

Fixes #3526 (closed) Issue: #2089 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i3526-invalidate-tls-client-threads