Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !3519

i#3507: Relax commit increment options

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i3507-mem-options into master Apr 08, 2019
  • Overview 1
  • Commits 2
  • Pipelines 0
  • Changes 2

Changes the -heap_commit_increment and -cache_commit_increment options to no longer be strictly required to be smaller than all unit sizes, which made it a pain to change the increment size without also specifying every unit parameter, of which there are many. It was also impractical to raise the heap increment on UNIX due to the signal special heap's maximum size. Now, each unit simply caps its own increment size to a maximum of its unit size.

Also fixes a regression: an assert when using -no_vm_reserve.

Tested by running with "-no_vm_reserve -heap_commit_increment 8M -cache_commit_increment 8M".

Fixes #3507 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i3507-mem-options