Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !3492

i#3427 detach flakiness: Add two derivatives of the api.detach_spawn test.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Hendrik Greving requested to merge i3427-add-detach_spawn-derivative-tests into master Mar 29, 2019
  • Overview 41
  • Commits 9
  • Pipelines 0
  • Changes 5

The remaining items in #3427 were non-issues, see comment in #3427. Instead, this patch is adding two tests. Both are derivatives of api.detach_spawn.

api.detach_spawn_quick_exit: Adds start/stop_and_cleanup re-attach to api.detach_spawn. It only spawns one thread. The thread is synch'd such that it exits while running native. This case is not supported by DynamoRIO's dr_app_stop w/o detach, but must work w/ dr_app_stop_and_cleanup().

api.detach_spawn_stress: Adds start/stop_and_cleanup re-attach to api.detach_spawn. Increase the number of spawned parent and child threads to 25 each, spawning a total number of 25 + 25 * 25 = 650 threads at a time, but limit the re-spawn loop. Like api.detach_spawn, this test is currently flaky in 32-bit, and very rarely flaky in 64-bit. #3427 covers the 64-bit failure. I have added a comment to #2694.

Issues: #3427, #2694

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i3427-add-detach_spawn-derivative-tests