Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !3419

i#3385 Fix crash for ELFs which have late .dynstr segment

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Assad Hashmi requested to merge i3385-elf-dynstr-fix into master Mar 04, 2019
  • Overview 40
  • Commits 10
  • Pipelines 0
  • Changes 8

This PR is a follow-on from the discussion in issue https://github.com/DynamoRIO/dynamorio/issues/3385

The sort of questions I've been trying to answer are (based on my simple understanding of the code):

  • Which part(s) of the code maps the segments into memory? Just module_add_segment_data() or something else as well?
  • When looking for which part of the ELF loader calls mmap() I noticed they go via post_system_call(). Why?

I suppose the main question is why not map+load the whole file into memory and populate the relevant DR data structures (os_module_data_t etc) in one go rather than mapping+loading piecemeal?

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i3385-elf-dynstr-fix