Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !3405

i#3348 sym conflicts: use "d_r_" prefix on core string routines

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i3348-our-string into master Mar 01, 2019
  • Overview 1
  • Commits 3
  • Pipelines 0
  • Changes 73

Rename our_snprintf to d_r_snprintf per the new global variable naming policy. Rename our_*sscanf to d_r_*sscanf.

Rename DR's internal string routines to use a d_r_ prefix to reduce name conflicts with static linking. Because on Windows we still want to use the standard names (because we import from ntdll), we resort to macro renames within core/ just like we're doing with snprintf.

Remove includes of string.h in core/ to avoid macros and inlined functions pulling in libc functions, now that our versions use different names.

Issue: #3348

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i3348-our-string