Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !3249

i#2270 itimer detach: Remove alarm handlers before synching with threads.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge i2270-ignore-alarms-earlier into master Nov 05, 2018
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: Carrotman42

If an alarm is received by a thread after it has blocked in check_wait_at_safe_spot but before the detaching thread sends the SUSPEND_SIGNAL, it is possible the fcache_unit_areas lock is being held in record_pending_signal when the SUSPEND_SIGNAL is received. Since the receiving thread was already marked as waiting at a safe spot, we synchronize with the thread and detach it, and the fcache_unit_areas lock is never unlocked.

Issue: #2270 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i2270-ignore-alarms-earlier