Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !3124

i#3048 func-trace: Use dr_get_proc_address to find dynsym first

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/Louis-Ye/i3048-func-trace-find-dynsym-first into master Aug 14, 2018
  • Overview 11
  • Commits 7
  • Pipelines 0
  • Changes 1

Created by: Louis-Ye

If the kernel enables mechanisms like remapping sections in the module at runtime (i.e., hugepage_text, related issue #2566 (closed)), the full_path of the module_data_t provided in drmgr_register_module_load_event callback could be invalid, since the original module file could already be deleted. This leads to the failure of finding PC for a particular function in memtrace func-tracing feature, given drsym_lookup_symbol depends on loading the original module file by path. This PR is a partial fix to make function tracing feature works under scenarios like hugepage_text by using dr_get_proc_address before calling drsym_lookup_symbol. This way, we can still catch the target function if its name is in the dynamic symbol table. However, if a target function is not in the dynamic symbol table and the kernel is running with features like hugepage_text, then the function tracing feature would still fail to trace this target function.

Fixes #3048 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Louis-Ye/i3048-func-trace-find-dynsym-first