Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !3075

i#3074: trace tool error strings

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i3074-tool-errors into master Jun 29, 2018
  • Overview 2
  • Commits 2
  • Pipelines 0
  • Changes 12

Adds analysis_tool_t::get_error_string() and uses it to provide error codes for failures in tool initialization, process_memref(), or print_stats(). This is particularly important for tools like opcode_mix which can fail to decode during processing.

Changes analyzer_t to abort trace processing on a failure in process_memref() and return the error code.

Eliminates most direct printing to stderr via ERRMSG() in tools and analyzers and replaces it with setting an error string and propagating child error strings.

Tested with deliberate errors in the opcode_mix, cache_simulator, and tlb_simulator tools.

Fixes #3074 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i3074-tool-errors