Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !2867

i#2723 audit debug asserts: use fatal error macro in dynamorio_take_over_threads

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge i2723-assert-take-over-threads into master Mar 05, 2018
  • Overview 2
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: Carrotman42

Previously, if we weren't able to take over all threads after a few retries we would have a debug-level assert but otherwise continue on with running the application. This can cause lots of correctness problems in the application, and it would be better to cleanly crash ahead of time rather than wait for an application crash to happen.

Issue #2723

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i2723-assert-take-over-threads