Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !2807

i#2805: use trylock to avoid hang

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i2805-safe-locks into master Jan 17, 2018
  • Overview 1
  • Commits 3
  • Pipelines 0
  • Changes 4

Adds missing synchronization on reads of tsd->synch_perm in thread_synch_state_no_xfer() and thread_synch_check_state(), using a trylock to avoid hanging on a suspended thread that holds tsd->synch_lock. On trylock failure, both routines fail, which then prevents unsafe signal delivery.

TODO: try to create a test that reproduces the hang: it will not be easy and if it's not reliable it's not clear how much effort to put into it...

Fixes #2805 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i2805-safe-locks