Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !2803

i#2799: Make sure dstack_offs is 8-byte aligned on ARM.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge arm-dstack-offset into master Jan 12, 2018
  • Overview 15
  • Commits 13
  • Pipelines 0
  • Changes 3

Created by: fhahn

2e9f20e4 made get_clean_call_switch_stack_size() 8-byte aligned for ARM, which is required by the "Procedure Call Standard for the ARM Architecture [AAPCS]" [1]. priv_mcontext_t on ARM contains 17 4-byte slots, which is why an extra adjustment is needed in insert_push_all_registers.

[1] http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.faqs/ka4127.html

Unfortunately I do not have access to AArch32 HW for a couple of days and cannot verify if that fixes the AArch32 problem for now.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: arm-dstack-offset