Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !2747

i#2708 trace discontinuity: add test, fix bugs found by test

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i2638-trace-gaps-and-markers into master Dec 07, 2017
  • Overview 1
  • Commits 2
  • Pipelines 0
  • Changes 17

Extends the trace_invariants test from #2638 (closed) to ensure there's no discontinuity in control flow not indicated by a branch or a kernel xfer marker.

Adds an online trace_invariants test.

Switches the trace_invariants test to run pthreads.ptsig on UNIX, which is marked un-FLAKY, to test both threads and signals, and on winxfer on Windows.

Fixes several issues found by this new test:

  • Adds TRACE_TYPE_INSTR_SYSENTER to mark the PC discontinuity from OP_sysenter.
  • Adds proper handling of a mid-bb fault in offline trace conversion by looking ahead after each memref to see whether there's a marker.
  • #2011 (closed) follow-up: fixes the zero-iter code from 2772b0bd which it turns out only worked for offline traces. For online, the top-of-bb instr is jecxz, so the instr type and size were wrong.
  • Fixes pipe write splitting to avoid separating an instr from its bundle entries.
  • Avoids a marker for a thread init kernel xfer event on Windows.

Fixes #2708 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i2638-trace-gaps-and-markers