Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !2531

i#2509 AArch64 selfmod: Obtain PC from icache instr itself.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge i2509-icache-op-pc into master Jul 12, 2017
  • Overview 17
  • Commits 10
  • Pipelines 0
  • Changes 4

Created by: egrimley

When mangling an ISB instruction we need the PC of the following instruction, which will be the target after flushing fragments. Previously we used get_app_instr_xl8(next_instr), but the next instruction might be instrumentation, in which case the translation fails. So use get_app_instr_xl8(instr) + AARCH64_INSTR_SIZE, instead.

Also, because of the potential side exit, terminate a basic block on OP_isb, enforce this rule in client_process_bb(), and document this restriction.

Fixes #2509 (closed)

Change-Id: Ifcedb70fae7360c791e5857813b4d8d55fdc7471

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i2509-icache-op-pc