Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !2514

On ARM and AArch64, do not fail when no encoding is found.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge iX-encode-fail into master Jul 10, 2017
  • Overview 2
  • Commits 2
  • Pipelines 0
  • Changes 3

Created by: egrimley

Make instr_encode_arch() return NULL, without an assertion failure, if no encoding is found. The failure to encode might indicate an internal error, but this function is also called from the API, whose documented behaviour is to return NULL.

Also, on AArch64, move the code to handle OP_xx from codec.c to encode.c because if encode_common() accepts OP_xx then we cannot recognise a failure to encode from its uint return value.

Change-Id: I38f582c30481bb447c0a079ef12a5a80562f7176

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: iX-encode-fail