Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !2323

i#1937: dynamically size signal frame xstate area

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i1937-signal-xstate into master Apr 04, 2017
  • Overview 1
  • Commits 2
  • Pipelines 0
  • Changes 10

Adds dynamic sizing of the xstate area in Linux signal frames to handle forward-going processor extensions.

Sends a signal at init time to obtain the size of the xstate area. If it is larger than the known size, adds an OP_xsave operation when updating the state of a delivered signal. This is expensive, which is why we avoided it before. Using OP_xsaveopt is future work once we have FEATURE_XSAVEOPT (part of i#1312).

Adjusts the pending signal heap allocations to be aligned properly for an in-place OP_xsave.

Several stack-allocated xstate structures no longer easily fit on the stack and are changed to two different kinds of heap buffers: one in TLS for uses that cannot easily free it locally (thread_set_self_context() and os_forge_exception()), and one on the regular heap (convert_frame_to_nonrt_partial()). Unfortunately I was only able to easily test os_forge_exception(). Our test suite is missing test paths for the others.

Fixes #1937 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i1937-signal-xstate