Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !2231

i#2224: handle win10's change in partial memory writes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i2224-win10-safe-write into master Feb 26, 2017
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 13

On win10, NtWriteVirtualMemory no longer returns the number of bytes written and instead returns -1! Thus, if the caller of safe_write_ex() cares about that, we fall back to a try-except version rather than using the system call.

Clarifies the dr_safe_read and dr_safe_write functions: that they fail if the bytes read or written is partial. Updates all callers who want to fail on a partial read or write to pass NULL instead of taking time to check the size read/written.

Fixes #2224 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i2224-win10-safe-write