Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Merge requests
  • !2182

i#2157 re-attach: add best-effort re-attach support

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Derek Bruening requested to merge i2157-reattach into master Feb 14, 2017
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 27

While there are many globals that are not reset, we take a best-effort approach here and reset the ones that matter, allowing us to re-attach with a memtrace client and static DR.

Portions of this were initially based on https://codereview.appspot.com/13314047/ from Peter Goodman.

For DO_ONCE, an incremented counter is used.

For numerous other globals, at exit time if doing_detach is set we reset them to NULL.

For locks, we simply reset count_times_acquired but leave the deleted field as it does not matter much (part of the whole theme here: this may never be rock-solid for unusual option combinations but our goal is supporting the common case).

For drreg, with the new multi-init feature we have to zero the options at exit time.

Adds several tests by adding loops around existing start/stop tests, but stops short on burst_threads until i#2175 is fixed.

Review-URL: https://codereview.appspot.com/318520043

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: i2157-reattach