Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Issues
  • #5052
Closed
Open
Issue created Aug 17, 2021 by Administrator@rootContributor

ASSERT: When running codec.py to generate aarch64 instructions, error triggers exception

Created by: joshua-warburton

Describe the bug When building and an invalid encoding is set in codec.txt codec.py should display a helpful error telling you exactly where the error is. Unfortunately, there is a bug in creating the error and it throws a TypeError instead

Traceback (most recent call last):
  File "./codec.py", line 489, in <module>
    main()
  File "./codec.py", line 477, in main
    consistency_check(patterns, opndtab)
  File "./codec.py", line 413, in consistency_check
    pattern_to_str(p)))
TypeError: pattern_to_str() takes exactly 4 arguments (1 given)

To Reproduce Steps to reproduce the behavior:

  1. Change an instruction so that not all of the masked bits are accounted for, such as:
0x001101010000001100xxxxxxxxxxxx  n  ld1r   q0 : memvr
  1. Run codec.py

Expected behavior A traceback like below should be printed

Traceback (most recent call last):
  File "./codec.py", line 489, in <module>
    main()
  File "./codec.py", line 477, in main
    consistency_check(patterns, opndtab)
  File "./codec.py", line 413, in consistency_check
    pattern_to_str(*p)))
Exception: Unhandled bits:
 x                               in:
0x1011110xxxxxxx001001xxxxxxxxxx urshr d0 : d5 sd_sz immhb

Versions

  • What version of DynamoRIO are you using?
    • HEAD
  • Does the latest build from https://github.com/DynamoRIO/dynamorio/releases solve the problem?
    • No
  • What operating system version are you running on? ("Windows 10" is not sufficient: give the release number.)
    • N/A
  • Is your application 32-bit or 64-bit?
    • N/A
Assignee
Assign to
Time tracking