Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • D dynamorio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,467
    • Issues 1,467
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 44
    • Merge requests 44
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • DynamoRIO
  • dynamorio
  • Issues
  • #3794
Closed
Open
Issue created Aug 20, 2019 by Derek Bruening@derekbrueningContributor

[cleanup] export opnd.h to all of core/

Today arch/opnd.h is only manually imported, since it is rarely needed inside core/. However, we have some public headers that want its types and defines.

Today we have this in os_exports.h:

/* XXX: reg_id_t is not defined here, use ushort instead */
ushort
os_get_app_tls_base_offset(ushort /*reg_id_t*/ seg);
ushort
os_get_app_tls_reg_offset(ushort /*reg_id_t*/ seg);
void *
os_get_app_tls_base(dcontext_t *dcontext, ushort /*reg_id_t*/ seg);

New code for #2350 (closed) wants to use DR_NUM_GPR_REGS in a public header. We already have a separate internal define in arch.h NUM_GP_REGS.

I do not think there are any circular dependencies or other roadblocks to including opnd.h in arch_exports.h. The only cost would be build time.

Assignee
Assign to
Time tracking