Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !6725

Update to workbox-webpack-plugin v4

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/r0ughnex/feature/update-to-workbox-webpack-plugin-v4 into master Mar 28, 2019
  • Overview 5
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: r0ughnex

DESCRIPTION:

  • Resolves #6659 (closed): Updated the workbox-webpack-plugin from v3 to latest v4 and also tested some of the new configuration options such as skipWaiting and cleanupOutdatedCaches after ejecting the app.

  • Resolves #6243 (closed): The new version automatically solves the issue where a registered service worker still tries to load an old resource, after workbox has cleaned up its old cache after an update.

TESTS COMPLETED:

  • Change the app code to serviceWorker.register() and run build, then check if workbox caches the relevant files and if the service worker installs correctly and triggers the onSuccess callback.

  • Add flag skipWaiting: true to the webpack.config.js, then update the app code and perhaps also the version number in package.json, then repeat the test above and check if the new service worker takes over the application and triggers the onUpdate callback. Older outdated workbox caches should be deleted at the point (from logs visible on the dev console in localhost)

  • Add flag cleanupOutdatedCaches: false, repeat the test above and check if the new service worker takes over the application. Older outdated workbox cache should not deleted now (this option is only available in versions 4.x.x and above).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/r0ughnex/feature/update-to-workbox-webpack-plugin-v4